Add Pixel API v2 #731
Add Pixel API v2 #731
Conversation
There was a problem hiding this comment.
Looks good. Not gone through all the unrelated changes, but glanced.
Nice one for testing the change in strand length on dotstars.
The Wire1 guard around rtc makes me think we should try the users i2c alt bus. I've also got some distant thought about setting pins (even though they are defined already) and calling begin on wire1 for some arch's.
https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/pull/731/files#diff-b9c00d1d47c0c0a741a32aa31e52ddff1573173e965c8e76d7567527e8754f1cR149
The build target skips and generates are a bit confusing to view this way, but the couple of renames I checked seem to be matched with an add file for the lost targets so think it's okay. We should of course verify they're all still built + skipped correctly.
This pull request updates the
src/pixelscomponent for compatibility with WipperSnapper_Proto API v2.pixels/controller- Routes messages using the pixels.proto API to the appropriate hardware and model classes, controls, and tracks the state of pixel strands.pixels/model- Provides an interface for creating, encoding, and parsing messages from pixels.proto.pixels/hardware- Interface for interacting with NeoPixel or Dotstar pixel strands .Minor:
add_text_to_terminal()is disabled, for now as it is out of scope of this PR and was required to get FunHouse working for DotStar TestingTesting
Board: Adafruit Feather ESP32-S2
Component: Built-in Status NeoPixel
✅ Init
✅ Remove/Deinit
✅ Write
✅ Write after deinit
✅ Off after deinit (bug)
Board: Adafruit FunHouse ESP32-S2
Component: 5x DotStars
✅ Init
✅ Remove/Deinit
✅ Write 5x DotStars
✅ Write 4x DotStars
✅ Write after deinit
✅ Off after deinit (bug)